Messages in this thread | | | Subject | Re: [PATCH 1/7] [RFC] UBI: Export next_sqnum() | From | Artem Bityutskiy <> | Date | Mon, 21 May 2012 17:00:54 +0300 |
| |
On Mon, 2012-05-21 at 15:34 +0200, Richard Weinberger wrote: > > + /* TODO: Before checking version - check the CRC. > > The CRC covers only the fastmap data, not the super block.
Everything should be protected with CRC.
> > for (i = 0; i< nblocks; i++) { > > + /* TODO: you basically perform the scanning here - you should > > + * share the same code as we use in scan.c: use process_peb(). > > + */ > > What exactly do you mean by that? > process_eb() will not help much because the fastmap data is written > "raw" to the flash. (Without any interaction from the WL sub-system)
It still contains EC and VID headers. So you can use the existing code for scanning it.
-- Best Regards, Artem Bityutskiy [unhandled content-type:application/pgp-signature] | |