[lkml]   [2012]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v3 1/2] x86: Define early read-mostly per-cpu macros

    * Vlad Zolotarov <> wrote:

    > On Monday, May 21, 2012 10:46:26 AM Ingo Molnar wrote:
    > > * Vlad Zolotarov <> wrote:
    > > > Some read-mostly per-cpu data may need to be declared or defined early,
    > > > so it can be initialized and accessed before per_cpu areas are
    > > > allocated.
    > > >
    > > > Only the data that resides in the per_cpu areas should be read-mostly,
    > > > as there is little benefit in optimizing cache lines on initialization.
    > > >
    > > > Signed-off-by: Vlad Zolotarov <>
    > > > Signed-off-by: Ido Yariv <>
    > > > Signed-off-by: Shai Fultheim <>
    > >
    > > That's not a valid signoff chain. If you send me a patch then
    > > you should be the last SOB - but as the author you should be the
    > > first SOB as well. I edited the two SOBs to be Acked-by's.
    > Thanks, Ingo. I understand. However the "history" of this
    > patch is not as simple as u represent. ;)
    > It was originally written by Ido and I just posted it (then I
    > put my SOB at the end of SOB list). But after u noted that it
    > didn't compile on !SMP i reworked it but yet Ido did at least
    > half of the coding, so I put my SOB at the first place (as I
    > was the last one writing the code) and then Ido's as he
    > actually wrote the code in this patch as well and I do wanted
    > to give him a credit.

    The proper way to do that is to add a "Originally-From: " tag,
    or to keep him as the author (and first SOB) and desccribe your
    own changes as comments between the SOBs:

    Signed-off-by: Original Author
    [ cleaned up the code a bit ]
    Signed-off-by: Second Author
    [ restructured it ]
    Signed-off-by: You

    > Do u still think changing his (Ido's) SOB to Acked-by was the
    > right thing to do?

    If they agree with it then you can send it to me that way - or
    the above way, or you can add any extra authors in a copyright
    notice - but the signoff chain should be a chain, with the
    primary author as the first SOB and the person sending me the
    patch being the last SOB.



     \ /
      Last update: 2012-05-21 15:21    [W:0.026 / U:48.900 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site