Messages in this thread | | | Date | Sun, 20 May 2012 22:32:00 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: twl6040-vibra: Update for device tree support |
| |
On Wed, May 16, 2012 at 10:55:13PM +0300, Ujfalusi, Peter wrote: > Hi Dmitry, > > On Wed, May 16, 2012 at 10:35 PM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > So in this case why don't you have parent parse all DT data and > > construct instance of pdata for vibra driver to consume? > > If there is a need to change the parameters (add new ones for example) > for the vibra driver in this way the change in code only need to be > done in the vibra driver. > If the MFD core would construct the pdata, in this case I would need > to modify both the MFD core and vibra driver.
Hmm, I am getting:
CC drivers/input/misc/twl6040-vibra.o drivers/input/misc/twl6040-vibra.c: In function ‘twl6040_vibra_probe’: drivers/input/misc/twl6040-vibra.c:263:9: error: implicit declaration of function ‘of_find_node_by_name’ [-Werror=implicit-function-declaration] drivers/input/misc/twl6040-vibra.c:263:42: warning: initialization makes pointer from integer without a cast [enabled by default] cc1: some warnings being treated as errors make[1]: *** [drivers/input/misc/twl6040-vibra.o] Error 1 make: *** [drivers/input/misc/twl6040-vibra.o] Error 2
it looks like there is no stub for of_find_node_by_name().
Thanks.
-- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |