Messages in this thread | | | Date | Sun, 20 May 2012 17:40:03 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH] regulator: core: use correct device for device supply lookup |
| |
On Sunday 20 May 2012 02:31 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Sun, May 20, 2012 at 01:04:05PM +0530, Laxman Dewangan wrote: > >> ldo2_reg: ldo2 { >> :::::::: >> /** regulatr entry */ >> :::::::::::: >> ldo2-supply =<&ldo1_reg>; /* So ldo1 supply the ldo2. */ > This mapping should be moved up to the chip top level; this is just like > any other supply for the chip. >
Ok, After moving this mapping (ldo2-supply = <&ldo1_reg>;) to top level under tps65911, then it worked without core driver changes. Becasue at this time, the ldo2->desc->supply_name = "ldo2" get find on the chip level node and then it return the regulator node properly.
>> ldo1 registration went fine. >> During ldo2 registration, I passed the regulator_desc->supply_name as ldo2. > I'd be somewhat surprised if this is what the pin is actually called, > idiomatically the supply name should be whatever the pin is named on the > chip. Yes, I need to add the code in tps65911-regulator.c to use the proper pin name as per datasheet for looking for input supply. Like "vcc3" is the pin name for ldo6,ldo7 and ldo8 supply and hence look for "vcc3-supply" in the chip level rather than "ldo6-supply" or "ldo7-supply" etc. I will post the patch for these changes.
| |