lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100
    Dear Greg,

    Am 30.04.2012 04:13, schrieb Greg KH:
    > On Thu, Apr 12, 2012 at 12:40:30AM +0200, Markus Franke wrote:
    >> This patch adds a 1-wire slave device driver for the DS28E04-100.
    >>
    >> Signed-off-by: Markus Franke<franm@hrz.tu-chemnitz.de>
    >> Acked-by: Evgeniy Polyakov<zbr@ioremap.net>
    >
    > You have a lot of checkpatch warnings and errors, and you are creating

    Don't have a clue what you mean. You were able to apply the patch
    successfully in the past.

    > new sysfs files with no documentation at all as to what you are doing,
    > and why you are doing it. sysfs binary files at that, which should not
    > be used by ANY code that is trying to intrepret the data being sent to
    > those files, sysfs binary files are for "pass-through" mode only.

    Well, I just stuck to the way things are done in already existing
    drivers e.g. drivers/w1/slaves/w1_ds2433.c

    @Evgeniy: Any comments on this?

    Best regards,

    Markus Franke



    \
     
     \ /
      Last update: 2012-05-02 23:01    [W:0.026 / U:188.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site