[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[GIT PULL 0/5] perf/annotate fixes and improvements
Hi Ingo,

Please consider pulling,

- Arnaldo
The following changes since commit 38b31bd0cefbb0e69a182d9a94b09a7e648549dc:

perf annotate browser: Don't draw jump connectors for out of function jumps (2012-04-25 14:18:42 -0300)

are available in the git repository at:

git:// perf/annotate

for you to fetch changes up to 0822cc80d9aee026b1ebe43c02dc01e0a0227864:

perf annotate browser: Don't display 0.00 percentages (2012-04-27 17:13:53 -0300)

Perf annotate improvements and fixes:

. Current output:

push %rbp
mov %rsp,%rbp
→ callq mcount
movzwl 0x6(%rsi),%edx
and $0x7fff,%dx
test %rdi,%rdi
┌─────↓ jne 20
│ 17: xor %eax,%eax
│ 19: leaveq
│ ← retq
│ nopl 0x0(%rax,%rax,1)
└─→20: mov (%rdi),%rax
test %rax,%rax
↑ je 17
movzwl (%rsi),%ecx
movzwl 0x2(%rsi),%r9d
movzwl 0x4(%rsi),%r8d
movzwl %cx,%esi
movzwl %r9w,%r10d
shl $0x9,%esi
lea (%rsi,%r10,4),%esi
lea (%r8,%rsi,1),%esi
and 0x10(%rdi),%si
movzwl %si,%esi
mov (%rax,%rsi,8),%rax
1.63 test %rax,%rax
↑ je 19
nopw 0x0(%rax,%rax,1)
4.88 60: cmp %cx,(%rax)
↓ jne 7e
cmp %r9w,0x2(%rax)
↓ jne 7e
cmp %r8w,0x4(%rax)
↓ jne 79
test %dx,0x6(%rax)
↑ jne 19
79: cmp %r8w,0x4(%rax)
86.99 7e:↑ ja 17
3.25 mov 0x10(%rax),%rax
3.25 test %rax,%rax
↑ jne 60
← retq

. Changes:

- Don't show the big vertical line.

- Add an arrow to the right before call instructions

- Scrap bogus loop detection and instead start showing
arrows from jump (fwd or back) instructions to its targets
when cursor is on jump instruction. Press 'j' to toggle this.

Signed-off-by: Arnaldo Carvalho de Melo <>

Arnaldo Carvalho de Melo (5):
perf annotate browser: Add a right arrow before call instructions
perf ui browser: Add method to draw up/down arrow line
perf annotate browser: Show current jump, back or forward
perf annotate browser: Remove the vertical line after the percentages
perf annotate browser: Don't display 0.00 percentages

tools/perf/ui/browser.c | 54 ++++++++++++++++++++++++++++--
tools/perf/ui/browser.h | 4 +--
tools/perf/ui/browsers/annotate.c | 66 ++++++++++++++++++-------------------
3 files changed, 86 insertions(+), 38 deletions(-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2012-05-02 22:21    [W:0.076 / U:9.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site