Messages in this thread | | | Date | Wed, 2 May 2012 13:13:18 -0400 | From | Joe Korty <> | Subject | Re: checkpatch: kstrtol fix |
| |
On Wed, May 02, 2012 at 12:13:22PM -0400, Guenter Roeck wrote: > On Wed, 2012-05-02 at 11:10 -0400, Joe Korty wrote: >> kstrtol is a substitute for simple_strtol() only when when second >> arg of simple_strtol() is NULL. For any other value the functionality >> of simple_strtol() cannot be implemented in terms of kstrtol. > > If there _are_ uses of > simple_strtol() where the second argument is not used for error checking > but for some other purpose, I am sure that an alternative solution can > be found which does not require simple_strtol(). Or just live with the > warning for those cases. > > Thanks, > Guenter
And of course the burning question is, what was the compelling reason kstrtol wasn't made upwards-compatible with strtol? It just seems gratituous to have that little bit of incompatibility introduced into the kernel.
Joe
| |