Messages in this thread | | | From | Sasha Levin <> | Date | Wed, 2 May 2012 15:49:41 +0200 | Subject | Re: [PATCH] net: l2tp: unlock socket lock before returning from l2tp_ip_sendmsg |
| |
On Wed, May 2, 2012 at 3:28 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Good catch, but please use existing code style in this function. > > rc = -EDESTADDRREQ; > if (sk->sk_state != TCP_ESTABLISHED) > goto out; > > Also, please add in your commit message bug origin to ease stable team > work (not counting reviewers work) > > Bug added in commit 2f16270f41e1 (l2tp: Fix locking in l2tp_ip.c) > > Really, given the amount of patches you already sent, you should already > know that. > > Thanks > >
Understood. I'll resend. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |