lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] scsi: Silence unnecessary warnings about ioctl to partition
    Il 02/05/2012 12:54, Alan Cox ha scritto:
    >>> > > Since I have seen warnings from lots of commands, including some proprietary
    >>> > > userspace applications, I don't think disallowing the ioctls for processes
    >>> > > with CAP_SYS_RAWIO will happen in the near future if ever. So lets just
    >>> > > stop warning for processes with CAP_SYS_RAWIO for which ioctl is allowed.
    >> >
    >> > NACK. I would bet that all the warnings you've seen are for ioctl that
    >> > would have failed anyway with ENOTTY.
    > Then we don't need the bogus warning do we.

    Sure, but then disallowing the ioctls for processes with CAP_SYS_RAWIO
    will not cause regressions and _can_ happen. The transition period only
    needs to be prolonged for SG_IO, the only one that was reported in the
    wild, until people have time to fix their bugs or (I hope not) we give
    up and implement a very restrictive filter for SCSI commands sent to
    partition.

    The right patch is one that prepares for these step,
    http://permalink.gmane.org/gmane.linux.kernel/1254625 for example. It
    leaves the warning only for SG_IO, and silently blocks the rest (more
    rationale in the commit message there).

    However, that patch should be applied only at the beginning of the merge
    window, not at the end of the release cycle.

    Paolo


    \
     
     \ /
      Last update: 2012-05-02 13:41    [W:0.022 / U:0.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site