lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -v11 04/30] PCI: Add busn_res into struct pci_bus.
    From
    On Tue, May 1, 2012 at 12:28 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    > On Tue, May 1, 2012 at 8:40 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
    >>>> bridge's Subordinate Bus Number in config space == bus->subordinate ==
    >>>> bus->busn_res.end (correct me if I'm wrong).  I don't like the
    >>>> redundancy in this case.
    >>>
    >>> there are about 70 bus->subordinate reference and 40 bus->secondary reference.
    >>>
    >>> could try to update them in following patch set.
    >>
    >> If you're proposing this:
    >>  1. add bus->busn_res
    >>  2. remove bus->subordinate and bus->secondary
    >> I fully support that, and I'd like to merge both pieces at the same
    >> time (different patches is fine; I just want to make sure both pieces
    >> actually happen).
    >
    > yes. Can you consider applying  "removing bus->subordinate" patch set
    > to be applied after:
    > for-pci-busn-alloc
    > for-pci-root-bus-hotplug
    > for-pci-for-each-res-addon
    > for-pci-res-alloc
    >
    > otherwise there would be some extra rebase work for last three patch set.

    spent several hours today to have attached patch that will remove
    pci_bus secondary/subordinate.
    and tested with my setups with remove/scan test case.
    looks ok.

    need to apply it after
    for-pci-busn-alloc
    for-pci-root-bus-hotplug.

    Please check if i miss anything.

    Thanks

    Yinghai
    [unhandled content-type:application/octet-stream]
    \
     
     \ /
      Last update: 2012-05-02 07:41    [W:4.492 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site