lkml.org 
[lkml]   [2012]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 31/54] kmemleak: Fix the kmemleak tracking of the percpu areas with !SMP
Greg KH wrote...

> On Sat, May 19, 2012 at 03:27:33PM +0200, Christoph Biedl wrote:
> > Greg KH wrote...
> >
> > > 3.0-stable review patch. If anyone has any objections, please let me know.
> >
> > > From: Catalin Marinas <catalin.marinas@arm.com>
> > >
> > > commit 100d13c3b5b9410f604b86f5e0a34da64b8cf659 upstream.
> >
> > > + /* kmemleak tracks the percpu allocations separately */
> > > + kmemleak_free(fc);
> >
> > That one causes:
> >
> > mm/percpu.c: In function ‘setup_per_cpu_areas’:
> > mm/percpu.c:1877: error: implicit declaration of function ‘kmemleak_free’
> > make[1]: *** [mm/percpu.o] Error 1
> > make: *** [mm] Error 2
>
> Odd, it doesn't cause that problem here for me, what ARCH are you
> building for? I'm on x86-64.

x86-64 and ARM, not x86-32 for whatever reason, parisc not tested yet.

But, if I read the nested #ifdef right, CONFIG_CMP must be disabled to
hit that code.

> Actually, I don't think this is needed at all for 3.0 as percpu memleak
> handling went in with the patch you reference above, so this would cause
> problems on 3.0. So I'll go delete that patch from the queue, thanks
> for letting me know.

I'm fine with that descision.

Christoph
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-05-19 18:01    [W:0.344 / U:5.164 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site