lkml.org 
[lkml]   [2012]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] regulator: tps65910: add error message in case of failure
    Date
    Prints error message whenever there is failure on allocating
    resource. Also used the dev_* to print messages instead of pr_*

    Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
    ---
    drivers/regulator/tps65910-regulator.c | 12 ++++++++----
    1 files changed, 8 insertions(+), 4 deletions(-)

    diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
    index 5a8ad4e..560282c 100644
    --- a/drivers/regulator/tps65910-regulator.c
    +++ b/drivers/regulator/tps65910-regulator.c
    @@ -1107,7 +1107,7 @@ static struct tps65910_board *tps65910_parse_dt_reg_data(
    matches = tps65911_matches;
    break;
    default:
    - pr_err("Invalid tps chip version\n");
    + dev_err(&pdev->dev, "Invalid tps chip version\n");
    return NULL;
    }

    @@ -1158,12 +1158,16 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
    if (!pmic_plat_data && tps65910->dev->of_node)
    pmic_plat_data = tps65910_parse_dt_reg_data(pdev, &reg_node);

    - if (!pmic_plat_data)
    + if (!pmic_plat_data) {
    + dev_err(&pdev->dev, "Platform data not found\n");
    return -EINVAL;
    + }

    pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
    - if (!pmic)
    + if (!pmic) {
    + dev_err(&pdev->dev, "Memory allocation failed for pmic\n");
    return -ENOMEM;
    + }

    mutex_init(&pmic->mutex);
    pmic->mfd = tps65910;
    @@ -1187,7 +1191,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
    info = tps65911_regs;
    break;
    default:
    - pr_err("Invalid tps chip version\n");
    + dev_err(&pdev->dev, "Invalid tps chip version\n");
    return -ENODEV;
    }

    --
    1.7.1.1


    \
     
     \ /
      Last update: 2012-05-19 17:01    [W:0.039 / U:0.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site