Messages in this thread | | | Date | Sat, 19 May 2012 23:49:53 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 2/5] regulator: tps65910: set of_node for regulator register config |
| |
On Saturday 19 May 2012 11:18 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Sat, May 19, 2012 at 08:04:07PM +0530, Laxman Dewangan wrote: > > > >> -#ifdef CONFIG_OF >> - config.of_node = of_find_node_by_name(tps65910->dev->of_node, >> + if (reg_node) >> + config.of_node = of_find_node_by_name(reg_node, >> info->name); >> -#endif > ...it's changing the value that's being configured. The changelog > doesn't explain why this is being done. > > Also, why is the ifdef being removed - won't that break the build? Yaah there is no function for non-dt case and should we add that in of.h? static inline struct device_node *of_find_node_by_name(struct device_node *from, const char *name) { return NULL; }
In this case it will not need to have #ifdef CONFIG_OF in the client code?
| |