Messages in this thread | | | Date | Thu, 17 May 2012 20:51:46 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH 1/5] st: Use static class attributes |
| |
On Wed, May 16, 2012 at 08:56:13PM -0700, Lee Duncan wrote: > @@ -84,7 +84,8 @@ static int try_wdio = 1; > static int st_dev_max; > static int st_nr_dev; > > -static struct class *st_sysfs_class; > +extern struct class st_sysfs_class;
Umm ... 'extern' ...
> @@ -4283,6 +4284,11 @@ static void scsi_tape_release(struct kref *kref) > return; > } > > +struct class st_sysfs_class = { > + .name = "scsi_tape", > + .dev_attrs = st_dev_attrs, > +};
... and then you define it?
I think you meant to say "struct class st_sysfs_class;" at the top, and then later:
static struct class st_sysfs_class = { ...
> +struct device_attribute st_dev_attrs[] = {
Should also be static
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |