Messages in this thread | | | Date | Thu, 17 May 2012 16:51:17 -0700 | From | David Daney <> | Subject | Re: [PATCH 01/10] Use __kernel_long_t in struct timex |
| |
On 05/17/2012 03:56 PM, Linus Torvalds wrote: > On Thu, May 17, 2012 at 3:50 PM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: >> >> I think __word would be good too, *except* for the fact that >> especially in x86 land, I think there's the legacy confusion with >> "word" being 16-bit. Ugh. > > Looking at the x32 case, I have to say that "long" in general looks > horrible. Especially when we have things like > > typedef long long __kernel_long_t; > > (and __long really wouldn't look any nicer). Any sane person would go > "Eww" at looking at that - we're using 'long long' to typedef a type > that is named 'long'. > > It would make much more sense to use "__word" for reasons like that. > But I really don't think that works well in a x86 context. > > Other ideas? Maybe "__wordsize" would be less associated with x86 16-bit words? >
FWIW: "__abi_wordsize" to indicate that it is not really a property of the machine itself, but rather the ABI in use.
David Daney
| |