lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 00/10] Use __kernel_[u]long_t for x32 user space compatibility
On 05/17/2012 04:11 PM, H. Peter Anvin wrote:
> On 05/17/2012 04:07 PM, David Daney wrote:
>>
>> Has anybody checked how this affects MIPS n32 userspace?
>>
>> I think it totally breaks it.
>>
>
> Do you have any basis whatsoever for that statement?

You should have asked for a 'solid basis'.

My basis is that the name '__kernel_ulong_t' implies, in my mind, that
it would have the width of a kernel unsigned long.

Really it should be called something like __abi_alternate_ulong_t.

> This should have
> zero effect on any non-x32 platforms.

After further reflection on this, you are probably right.

Sorry for raising the alarm (or would that be crying Wolf?).

>
>> In addition, 109a1f32 (sysinfo: Use explicit types in<linux/sysinfo.h>)
>> is probably bad. I think it may need to be reverted, or somebody should
>> fix all the __kernel_{,u}long_t definitions for the ABI that may have
>> been broken by the change.
>
> You realize __kernel_[u]long_t didn't even exist until the 3.4 kernel,
> right?

Yes.

David Daney


\
 
 \ /
  Last update: 2012-05-18 01:41    [W:0.208 / U:29.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site