lkml.org 
[lkml]   [2012]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] floppy: convert to delayed work and single-thread wq
    On Wed, May 16, 2012 at 09:57:22PM +0200, Jiri Kosina wrote:
    > On Wed, 16 May 2012, Tejun Heo wrote:
    >
    > > > On Wed, May 16, 2012 at 12:37 PM, Jiri Kosina <jkosina@suse.cz> wrote:
    > > > > +       cancel_delayed_work_sync(&fd_timeout);
    > > > > +       cancel_delayed_work_sync(&fd_timer);
    > > > > +       destroy_workqueue(system_nrt_wq);
    > > >
    > > > Well, *that* doesn't look right.
    > > >
    > > > I think just a "flush_workqueue()" is in order.
    > >
    > > System wqs shouldn't be flushed (nothing guarantees that flush will
    > > finish in fixed amount of time). We probably should make that
    > > explicit by whining when someone tries to flush one of the system wqs.
    > > Here, the two cancel_delayed_work_sync() calls should be enough.
    >
    > Well, then I think this might be an issue for straightforward conversion
    > of floppy driver to system_nrt_wq -- see floppy_grab_irq_and_dma().

    Hmmm? flush_work() is fine. flush_workqueue() isn't. Am I missing
    something?

    --
    tejun
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-16 22:41    [W:0.033 / U:88.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site