[lkml]   [2012]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [vmw_vmci RFC 01/11] Apply VMCI context code
On Tue, 15 May 2012 08:06:58 -0700
"Andrew Stiegmann (stieg)" <> wrote:

> Context code maintains state for vmci and allows the driver
> to communicate with multiple VMs.
> Signed-off-by: Andrew Stiegmann (stieg) <>

Running checkpatch reveals the usual noise, and the following that
should be addressed.

ERROR: do not use C99 // comments
#272: FILE: drivers/misc/vmw_vmci/vmci_context.c:183:
+static bool ctx_exists_locked(uint32_t cid) // IN

ERROR: "foo * bar" should be "foo *bar"
#304: FILE: drivers/misc/vmw_vmci/vmci_context.c:215:
+ uid_t * user, struct vmci_ctx **outContext)

I don't mind the C99 style comments, but the // IN convention
is pretty useless and should be removed.

 \ /
  Last update: 2012-05-16 19:41    [W:0.167 / U:10.616 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site