lkml.org 
[lkml]   [2012]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/4] zsmalloc use zs_handle instead of void *
    From
    >>> It's not good abstraction.
    >>
    >> If we want good abstraction, then I don't think 'unsigned long' is
    >> either? I mean it will do for the conversion from 'void *'. Perhaps I
    >> am being a bit optimistic here - and I am trying to jam in this
    >> 'struct zs_handle' in all cases but in reality it needs a more
    >> iterative process. So first do 'void *' -> 'unsigned long', and then
    >> later on if we can come up with something more nicely that abstracts
    >> - then use that?

    ..snip..
    >>> No. What I want is to remove coupling zsallocator's handle with zram/zcache.
    >>> They shouldn't know internal of handle and assume it's a pointer.
    >>
    >> I concur. And hence I was thinking that the 'struct zs_handle *'
    >> pointer would work.
    >
    >
    > Do you really hate "unsigned long" as handle?
    ..snip,,
    >> Well, everything changes over time  so putting a stick in the ground
    >> and saying 'this must
    >> be this way' is not really the best way.
    >
    >
    > Hmm, agree on your above statement but I can't imagine better idea.
    >

    OK. Lets go with unsigned long. I can prep a patch next week when I am
    back from vacation unless somebody beats me to it.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-16 13:41    [W:0.029 / U:30.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site