Messages in this thread | | | Date | Tue, 15 May 2012 17:12:14 +0300 | From | Gleb Natapov <> | Subject | Re: [PATCH] EDD: Check for correct EDD 3.0 length |
| |
On Tue, May 15, 2012 at 02:49:45PM +0100, Alan Cox wrote: > > I do not see support for other spec to be important, but you are welcome > > to write support for it if you need it. The only way I see to check what > > spec edd info corresponds to is to calculate checksum according to both > > specs and see which one succeeds. > > No it doesn't work like that. This is a regression for existing working > systems. It needs to be reverted or fixed. If it was a new feature you'd > have a point - but it isn't. You've broken stuff, undo the breakage. > Code never supported anything but EDD4.0 spec. I checked history git. Code erroneously tried to interpret EDD3.0 info according to EDD4.0 spec providing garbage as a result.
-- Gleb.
| |