lkml.org 
[lkml]   [2012]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 125/179] libsas: remove expander from dev list on error
    Date
    From: Luben Tuikov <ltuikov@yahoo.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 5911e963d3718e306bcac387b83e259aa4228896 upstream.

    If expander discovery fails (sas_discover_expander()), remove the
    expander from the port device list (sas_ex_discover_expander()),
    before freeing it. Else the list is corrupted and, e.g., when we
    attempt to send SMP commands to other devices, the kernel oopses.

    Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
    Reviewed-by: Jack Wang <jack_wang@usish.com>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/scsi/libsas/sas_expander.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
    index c65af02..fbf0a09 100644
    --- a/drivers/scsi/libsas/sas_expander.c
    +++ b/drivers/scsi/libsas/sas_expander.c
    @@ -841,6 +841,9 @@ static struct domain_device *sas_ex_discover_expander(

    res = sas_discover_expander(child);
    if (res) {
    + spin_lock_irq(&parent->port->dev_list_lock);
    + list_del(&child->dev_list_node);
    + spin_unlock_irq(&parent->port->dev_list_lock);
    kfree(child);
    return NULL;
    }
    --
    1.7.9.6


    \
     
     \ /
      Last update: 2012-05-15 06:02    [W:0.025 / U:59.320 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site