lkml.org 
[lkml]   [2012]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 145/179] ALSA: sound/core/pcm_compat.c: adjust array index
    Date
    From: Julia Lawall <julia@diku.dk>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit ca9380fd68514c7bc952282c1b4fc70607e9fe43 upstream.

    Convert array index from the loop bound to the loop index.

    A simplified version of the semantic patch that fixes this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression e1,e2,ar;
    @@

    for(e1 = 0; e1 < e2; e1++) { <...
    ar[
    - e2
    + e1
    ]
    ...> }
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    sound/core/pcm_compat.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/core/pcm_compat.c b/sound/core/pcm_compat.c
    index 5fb2e28..91cdf94 100644
    --- a/sound/core/pcm_compat.c
    +++ b/sound/core/pcm_compat.c
    @@ -342,7 +342,7 @@ static int snd_pcm_ioctl_xfern_compat(struct snd_pcm_substream *substream,
    kfree(bufs);
    return -EFAULT;
    }
    - bufs[ch] = compat_ptr(ptr);
    + bufs[i] = compat_ptr(ptr);
    bufptr++;
    }
    if (dir == SNDRV_PCM_STREAM_PLAYBACK)
    --
    1.7.9.6


    \
     
     \ /
      Last update: 2012-05-15 05:41    [W:6.390 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site