lkml.org 
[lkml]   [2012]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry.
From
Date
On Mon, 2012-05-14 at 01:07 +0900, OGAWA Hirofumi wrote:
> Joe Perches <joe@perches.com> writes:
>
> > On Sun, 2012-05-13 at 07:03 -0400, Namjae Jeon wrote:
> >> So this patch use fat_msg_ratelimit function about this message to decrease this messages.
> > []
> >> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> >> index aca191b..b2cdbf4 100644
> >> --- a/fs/fat/dir.c
> >> +++ b/fs/fat/dir.c
> >> @@ -98,8 +98,8 @@ next:
> >>
> >> *bh = sb_bread(sb, phys);
> >> if (*bh == NULL) {
> >> - fat_msg(sb, KERN_ERR, "Directory bread(block %llu) failed",
> >> - (llu)phys);
> >> + fat_msg_ratelimit(sb, KERN_ERR, "Directory bread(block %llu) "
> >> + "failed", (llu)phys);
> >
> > Please don't split format strings.
> > It's much harder to grep.
>
> Please fight with 80 columns guys before requesting it.

That battle is long over.

from Documentation/CodingStyle:

Chapter 2: Breaking long lines and strings

[]

The limit on the length of lines is 80 columns and this is a strongly
preferred limit.
[]
However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.




\
 
 \ /
  Last update: 2012-05-13 18:41    [from the cache]
©2003-2011 Jasper Spaans