lkml.org 
[lkml]   [2012]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/7] drm: do not change selected options based on EXPERT mode
    Date
    EXPERT mode is designed to toggle visibility of config options. It should
    not have any other effect on config values. Imagine if a user wants to
    tweak a single value that is protected by EXPERT mode. If they enable
    EXPERT mode to change that single option, they might get side effects from
    other subsystems which they didn't expect. This makes EXPERT mode totally
    useless. Hence, simply let the user always select the framebuffer-console
    manually.
    Furthermore, with kmscon or wayland, users might want to disable CONFIG_VT
    which is currently automatically selected by DRM_KMS_HELPER through
    FRAMEBUFFER_CONSOLE if !EXPERT.

    Cc: David Airlie <airlied@linux.ie>
    Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
    ---
    drivers/gpu/drm/Kconfig | 1 -
    drivers/gpu/drm/nouveau/Kconfig | 1 -
    2 files changed, 2 deletions(-)

    diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
    index e354bc0..ded991c 100644
    --- a/drivers/gpu/drm/Kconfig
    +++ b/drivers/gpu/drm/Kconfig
    @@ -28,7 +28,6 @@ config DRM_KMS_HELPER
    tristate
    depends on DRM
    select FB
    - select FRAMEBUFFER_CONSOLE if !EXPERT
    select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
    help
    FB and CRTC helpers for KMS drivers.
    diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
    index 97a8126..d7e2536 100644
    --- a/drivers/gpu/drm/nouveau/Kconfig
    +++ b/drivers/gpu/drm/nouveau/Kconfig
    @@ -8,7 +8,6 @@ config DRM_NOUVEAU
    select FB_CFB_COPYAREA
    select FB_CFB_IMAGEBLIT
    select FB
    - select FRAMEBUFFER_CONSOLE if !EXPERT
    select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT
    select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
    select ACPI_WMI if ACPI
    --
    1.7.10.2


    \
     
     \ /
      Last update: 2012-05-13 18:41    [W:0.025 / U:29.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site