[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v4 7/7] x86/tlb: add tlb_flushall_factor into sysfs for user testing/tuning

    > Nowhere do you say this is x86 only, please fix that.


    > Yeah, another tunable that no one knows how to use.
    > Really, why is this here at all? As others pointed out, this really
    > looks like a debugging thing that almost no one will ever need, so
    > please, put it in debugfs.


    > Do the #ifdef in the .h file, not the .c file please, no matter how you
    > end up doing this (debugfs vs. sysfs.)


    > thanks,
    > greg k-h

     \ /
      Last update: 2012-05-11 03:41    [W:0.021 / U:73.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site