lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] ARM: tegra30: Add Tegra Memory Controller(MC) driver
    On Thu, May 10, 2012 at 10:42:32AM +0300, Hiroshi DOYU wrote:
    > Tegra Memory Controller(MC) driver for Tegra30
    > Added to support MC General interrupts, mainly for IOMMU(SMMU).

    I'll apply this, but:

    > +static inline u32 mc_readl(struct tegra30_mc *mc, u32 offs)
    > +{
    > + if (offs < 0x10)
    > + return readl(mc->regs[0] + offs);
    > + BUG_ON(offs < 0x3c);
    > + if (offs < 0x1f0)
    > + return readl(mc->regs[1] + offs - 0x3c);
    > + BUG_ON(offs < 0x200);
    > + if (offs < 0x228)
    > + return readl(mc->regs[2] + offs - 0x200);
    > + BUG_ON(offs < 0x284);
    > + if (offs < 0x400)
    > + return readl(mc->regs[3] + offs - 0x284);
    > + BUG();
    > +}

    That's a lot of BUG* calls. Same thing with the 1/4 patch in this
    series.

    We really should not have a BUG call in any driver, as you just stopped
    the whole system. I can understand this being there for debugging when
    you create the code originally, but as these are things no one should
    ever be able to hit now, you should remove them, right?

    Care to write a follow-on patch removing all of these BUG_ON and BUG
    calls in this and the drivers/memory/tegra20-mc.c driver?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2012-05-11 00:21    [W:0.024 / U:91.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site