lkml.org 
[lkml]   [2012]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] hwmon: coretemp: fix oops on cpu unplug
    On Tue, May 01, 2012 at 08:20:14AM -0700, Guenter Roeck wrote:
    > On Mon, Apr 30, 2012 at 09:18:01AM -0400, Kirill A. Shutemov wrote:
    > > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
    > >
    > > coretemp tries to access core_data array beyond bounds on cpu unplug if
    > > core id of the cpu if more than NUM_REAL_CORES-1.
    > >
    > [ ... ]
    > >
    > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    >
    > Looking at it again, you were right. Adding the check to get_core_online()
    > doesn't really help as the platform device is per CPU, not per core.
    >
    > Applied. I'll submit a separate patch to increase NUM_REAL_CORES.

    Actually, the problem is bigger.

    Documentation/cputopology.txt:
    ====
    2) /sys/devices/system/cpu/cpuX/topology/core_id:

    the CPU core ID of cpuX. Typically it is the hardware platform's
    identifier (rather than the kernel's). The actual value is
    architecture and platform dependent.
    ====

    We should not use core id as an index in an array since it's an arbitrary
    number (from kernel POV).

    --
    Kirill A. Shutemov


    \
     
     \ /
      Last update: 2012-05-01 23:41    [W:0.023 / U:184.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site