lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: orphan queued skbs if device tx can stall
    On Mon, Apr 09, 2012 at 10:39:54AM +0300, Michael S. Tsirkin wrote:
    > On Mon, Apr 09, 2012 at 03:33:54PM +0800, Herbert Xu wrote:
    > > On Mon, Apr 09, 2012 at 10:28:49AM +0300, Michael S. Tsirkin wrote:
    > > >
    > > > > 1) Doesn't this break local UDP push-back?
    > > >
    > > > What is meant by UDP pushback here? Two tap
    > > > devices communicating by UDP packets locally?
    > > > This was always broken, see below.
    > >
    > > I mean push-back from UDP transmission to the physical NIC.
    > >
    > > Your patch breaks that
    >
    > I think there's some misunderstanding. pushback is only disabled
    > for destinations that set IFF_TX_CAN_STALL. I expect that
    > no physical NICs set this flag - only tun and possibly
    > other userspace-controlled devices in the future.

    I'm talking about an app running in the guest transmitting UDP
    to the physical NIC via virtio/vhost. This will break with your
    patch.

    Cheers,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2012-04-09 10:31    [W:2.808 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site