[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v3 1/3] tegra, serial8250: add ->handle_break() uart_port op
    On 04/09/2012 01:48 PM, Dan Williams wrote:
    > The "KT" serial port has another use case for a "received break" quirk,
    > so before adding another special case to the 8250 core take this
    > opportunity to push such quirks out of the core and into a uart_port op.
    > Stephen says:
    > "If the callback function is to no longer live in 8250.c itself,
    > arch/arm/mach-tegra/devices.c isn't logically a good place to put it,
    > and that file will be going away once we get rid of all the board files
    > and move solely to device tree."
    > since 8250_pci.c houses all the quirks for pci serial devices this
    > quirk is similarly housed in of_serial.c. Once the open firmware
    > conversion completes the infrastructure details (CONFIG_TEGRA_SERIAL,
    > include/linux/of_serial.h, and the export) can all be removed to make
    > this self contained to of_serial.c.

    This still seems much to invasive.

    Again, what's wrong with simply keeping the quirk implementation where
    it is, and driving everything off the already-extant
    plat_serial8250_port.type == PORT_TEGRA flag?

    I believe all that's required here is to enhance struct struct
    serial8250_config (and hence 8250.c's uart_config[] quirk table) to be
    able to set the quirk function pointers as well as all the other exiting
    quirked variables.

     \ /
      Last update: 2012-04-09 21:51    [W:0.019 / U:134.596 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site