lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 1/4] of_serial: add support for setup quirks
    Date
    On Monday 09 April 2012, Dan Williams wrote:
    > Benign conversion of of_serial.c to offer the option of 'setup' quirks
    > similar to how 8250_pci.c houses the pci-serial-device quirks.
    >
    > A setup quirk allows custom uart_port ops to specified in the
    > of_serial_info data fed to each serial of_device_id.
    >
    > Tegra's 'break' quirk is the target consumer.
    >
    > Cc: Colin Cross <ccross@android.com>
    > Cc: Olof Johansson <olof@lixom.net>
    > Cc: Stephen Warren <swarren@nvidia.com>
    > Cc: Arnd Bergmann <arnd@arndb.de>
    > Cc: Grant Likely <grant.likely@secretlab.ca>
    > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    > ---
    > drivers/tty/serial/of_serial.c | 68 ++++++++++++++++++++++++++++------------
    > 1 files changed, 47 insertions(+), 21 deletions(-)

    I don't think this is a good idea. Aside from the bug that you introduce
    (you can no longer have multiple ports of the same type because of overwrite
    the static info->line number), it seems an unnecessary complication.
    Either just add the quirk to the of_serial file based on the compatible value,
    or do a trivial new driver that has a subset of the existing one you need,
    plus the quirk.

    Arnd


    \
     
     \ /
      Last update: 2012-04-09 20:51    [W:0.019 / U:92.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site