Messages in this thread | | | Date | Mon, 09 Apr 2012 11:34:48 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic() |
| |
> The proper way to resolve the problem that original commit tried to > solve is to avoid printing a stack dump from panic() when the either > of the following conditions is true: > > 1) TAINT_DIE has been set (this is done by oops_end()) > This indicates and oops has already been printed. > 2) oops_in_progress> 1 > This guards against the rare case where panic() is invoked > a second time, or in between oops_begin() and oops_end()
Oops. I guess can just revert it for now. Thanks for catching, Jason.
The proper solution is probably some variant of http://git.kernel.org/?p=linux/kernel/git/ak/linux-mce-2.6.git;a=shortlog;h=refs/heads/mce/xpanic
Let the caller pass in the proper action instead of all these hacks.
-Andi
| |