lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND][PATCH v2] block: remove plugging at buffered write time
Date
Wu Fengguang <fengguang.wu@intel.com> writes:

> Buffered write(2) is not directly tied to IO, so it's not suitable to
> handle plug in generic_file_aio_write().
[snip, moved]
> Note that plugging for O_SYNC writes is also removed. The user may pass
> arbitrary @size arguments, which may be much larger than the preferable
> I/O size, or may cross extent/device boundaries. Let the lower layers
> handle the plugging. Otherwise the plugging code here will turn the
> low level plugging into no-ops.

I assume you have some numbers to back this up, right? Care to share
those?

> Also moves unplugging for direct I/O from around ->direct_IO() down to
> do_blockdev_direct_IO().

This could be handled in a separate patch. Acked-by: Jeff Moyer
<jmoyer@redhat.com> for this part.

Cheers,
Jeff


\
 
 \ /
  Last update: 2012-04-09 16:37    [W:0.112 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site