lkml.org 
[lkml]   [2012]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][Trivial] Delete trailing whitespace from sound/soc/codecs/wm8994.c
On Mon, 9 Apr 2012, Michael Witten wrote:

> >> While reading through sound/soc/codecs/wm8994.c I noticed a fair
> >> amount of trailing whitespace. This patch gets rid of it.
> >>
> >> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> >
> > Jesper,
> >
> > is it really worth it? The code should have been fixed before merging,
> > yes, but once it's there, such fixups tend to only make people angry
> > (because they have to do unnecessary extra steps during git blame).
>
> If I may interject, I assume you mean that nobody wants to see the
> fact that somebody simply changed whitespace. However, the text of
> `git help blame' suggests that the `-w' flag obviates the issue:
>
> Ignore whitespace when comparing the parent's
> version and the child’s to find where the lines
> came from.
>
> Of course, I've never used it, so I may be mistaken in my
> interpretation.

That indeed does what it should do, but as it's not git default, then
quitting git blame and reruning it with '-w' seems to be equally annoying
to quitting git blame and reruning it with 'particular_commit~1"

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-04-09 02:31    [from the cache]
©2003-2011 Jasper Spaans