Messages in this thread | | | Date | Fri, 6 Apr 2012 16:35:29 -0700 (PDT) | From | Hugh Dickins <> | Subject | Re: [PATCH v2] hugetlb: fix race condition in hugetlb_fault() |
| |
On Fri, 6 Apr 2012, Andrew Morton wrote: > On Fri, 6 Apr 2012 16:10:13 -0700 (PDT) > Hugh Dickins <hughd@google.com> wrote: > > > > The resulting patch is okay; but let's reassure Chris that his > > original patch was better, before he conceded to make the get_page > > and put_page unconditional, and added unnecessary detail of the race. > > > > Yes, the v1 patch was better. No reason was given for changing it?
I think Chris was aiming to be a model citizen, and followed review suggestions that he would actually have done better to resist.
Hugh
| |