Messages in this thread | | | Date | Fri, 6 Apr 2012 16:30:04 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2/5] mtip32xx: Add new sysfs entry 'status' and fix restart port |
| |
On Fri, Apr 06, 2012 at 03:03:24PM -0700, Asai Thambi S P wrote: > On 4/6/2012 2:44 PM, Greg KH wrote: > > > On Fri, Apr 06, 2012 at 02:34:19PM -0700, Asai Thambi S P wrote: > >> On 4/6/2012 11:12 AM, Asai Thambi S P wrote: > >> > >>> On 4/5/2012 6:10 PM, Greg KH wrote: > >>> > >>>> On Thu, Apr 05, 2012 at 02:00:12PM -0700, Asai Thambi S P wrote: > >>>>> > >>>>> * Add support for detecting the following device status > >>>>> - write protect > >>>>> - over temp (thermal shutdown) > >>>>> * New sysfs entry 'status' created for this device, possible values - online, write_protect, thermal_shutdown > >>>> > >>>> All new (and existing) sysfs files must be documented in > >>>> Documentation/ABI/ please do so for these new ones when you add them to > >>>> the kernel. > >>> > >>> > >>> I was not aware of this. Thanks. I will a add new file for mtip32xx driver. > >>> > >> > >> > >> Greg, > >> > >> The sysfs entry for the disk is > >> /sys/block/rssda -> ../devices/pci0000:00/0000:00:01.0/0000:01:00.0/block/rssda > >> > >> Should I use /sys/block/<disk>/<entry> or > >> /sys/devices/.../block/<disk>/entry> in the doc file? > > > > What do the existing api files show for block devices? > > > > > I was looking into sysfs-driver-* files to create sysfs-driver-mtip32xx. > These files have paths like /sys/bus/pci/*, /sys/devices/*, > /sys/class/bluetooth/*, etc. > > There are sysfs-block-dm and sysfs-block-zram files with > /sys/block/dm-<num>/dm/* and /sys/block/zram<id>/*. If I have to follow > these, then the file would be sysfs-driver-rssd with /sys/block/<disk>/*. > > Let me know.
/sys/block/rs*/ would be the right place, right? You know the tree better than I do as you have this hardware and can see where in sysfs the files really are :)
thanks,
greg k-h
| |