Messages in this thread | | | Date | Fri, 6 Apr 2012 13:49:39 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [patch 0/2] cpusets, cpu_cgroup: disallow attaching kthreadd |
| |
On Fri, 6 Apr 2012, Peter Zijlstra wrote:
> Furthermore, the whole point of kthreadd's existence is so that we could > create kthreads without context. Placing it in a cgroup will ensure all > subsequently created kthreads do have context (including possible idle > threads). This seems like a particularly bad idea. >
I don't see it as context if the only thing you're doing is accounting with memcg (for slab) or or cpu. We're simply collecting statistics for a set of threads (possibly all kthreads, including kthreadd) and the best way to do this is leveraging the existing functionality of cgroups to setup the threads we want to collect for and the memcg kmem accounting is particularly a good indicator of kernel vs userjob-triggered slab allocation.
| |