lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/15] perf: Separate out trace-cmd parse-events from perf files
On Fri, Apr 06, 2012 at 12:47:52AM +0200, Frederic Weisbecker wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> Move the trace-event-parse.c code that originally came from trace-cmd into
> their own files. The new file will be called trace-parse-events.c, as
> the name of trace-cmd's file was parse-events.c too, but it conflicted
> with the parse-events.c file in perf that parses the command line.
>
> This tries to update the code with mimimal changes.
>
> Perf specific code stays in the trace-event-parse.[ch] files and
> the common parsing code is now in trace-parse-events.c and
> trace-parse-events.h.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Arun Sharma <asharma@fb.com>
> Cc: Namhyung Kim <namhyung.kim@lge.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> tools/perf/Makefile | 2 +
> tools/perf/util/trace-event-parse.c | 3135 ----------------------------------
> tools/perf/util/trace-event.h | 275 +---
> tools/perf/util/trace-parse-events.c | 3125 +++++++++++++++++++++++++++++++++
> tools/perf/util/trace-parse-events.h | 273 +++
> 5 files changed, 3405 insertions(+), 3405 deletions(-)
> create mode 100644 tools/perf/util/trace-parse-events.c
> create mode 100644 tools/perf/util/trace-parse-events.h

Err, maybe I'm missing something but why this additional step? I mean,
you could do:

patch 1: Add libtraceevent.a from trace-cmd
patch 2: Fixup perf so that it is ready to be switched to the new lib (specific
wrappers, etc)
patch 3: switch it to libtraceevent.a

Only three patches, right?

--
Regards/Gruss,
Boris.


\
 
 \ /
  Last update: 2012-04-06 13:39    [W:0.260 / U:27.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site