[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] printk: support structured and multi-facility log messages
On Thu, 2012-04-05 at 21:47 +0200, Kay Sievers wrote:

> Better?
> [root@mop ~]# cat /dev/kmsg
> 6,5,0; BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
> 6,6,0; BIOS-e820: 0000000000100000 - 000000001fffd000 (usable)
> 6 ,7,0; BIOS-e820: 000000001fffd000 - 0000000020000000 (reserved)

Not really, why the space between the 6 and the comma?

> This patch extends printk() to be able to attach arbitrary key/value
> pairs to logged messages,

Bad commit changelog.

It does not extend printk(). printk() is a function call.

It extends the message logging subsystem to include the
printk_emit() and vprintk_emit() functions, which can
add decidedly not arbitrary key/value pairs, but some
additional subsystem specific information.

> - Output of dev_printk() is reliably machine-readable now.

No, it's not.

An output header simply contains additional
structured information. The message portion
can still be arbitrary gobbledygook.

I still think this should be 3 patches not 1.

 \ /
  Last update: 2012-04-06 03:15    [W:0.083 / U:5.480 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site