lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] LEDS: LED module for DA9052/53 PMIC v2
On Wed, 22 Feb 2012 18:39:09 +0530
Ashish Jangam <ashish.jangam@kpitcummins.com> wrote:

> LED Driver for Dialog Semiconductor DA9052/53 PMICs.
>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>

This email was cc'ed to Dajun.Chen@diasemi.com. I'll assume that both
work correctly.

> drivers/leds/Kconfig | 8 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-da9052.c | 214 ++++++++++++++++++++++++++++++++++++++++++++

Looks OK. I added one little fixup:

--- a/drivers/leds/leds-da9052.c~leds-led-module-for-da9052-53-pmic-v2-fix
+++ a/drivers/leds/leds-da9052.c
@@ -40,7 +40,7 @@ struct da9052_led {
int brightness;
};

-unsigned char led_reg[] = {
+static unsigned char led_reg[] = {
DA9052_LED_CONT_4_REG,
DA9052_LED_CONT_5_REG,
};
This array could actually be made static within da9052_set_led_brightness().


\
 
 \ /
  Last update: 2012-04-06 00:55    [from the cache]
©2003-2011 Jasper Spaans