lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFT v3] watchdog: Convert orion_wdt driver to watchdog core
On Sun, Apr 01, 2012 at 06:02:30PM +0800, Axel Lin wrote:
> 2012/3/31 Jason Cooper <jason@lakedaemon.net>:
> > On Tue, Mar 27, 2012 at 07:20:40AM +0800, Axel Lin wrote:
> >> Convert orion_wdt driver to use watchdog framework API.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> >> ---
> >> Hi Jason, Andrew,
> >> I don't have this hardware handy.
> >> I'd appreciate if you can review and test this patch.
> >
> > Axel,
> >
> > Sorry for the delay, been a busy week.  I'm getting the following error:
> >
> > drivers/watchdog/orion_wdt.c:133:2: error: unknown field 'get_timeleft'
> > specified in initializer
> > drivers/watchdog/orion_wdt.c:133:2: warning: initialization from
> > incompatible pointer type
> >
> > What tag did you base this off of?  Are there any dependencies not in
> > mainline?
> I generate the patch base on linux-next tree.
> I just checked Linus' tree and this patch is appliable to Linus' tree.
> The required commit[1] is alread merged to Linus' tree now.
> Can you check it again?
> Thanks.

Ah, much better. I rebased it against v3.4-rc1 now that it's out.
Compiles without problems. I'll test this weekend most likely. I don't
have my watchdog code in front of me atm.

thx,

Jason.

> [1] http://www.linux-watchdog.org/cgi-bin/gitweb.cgi?p=linux-watchdog.git;a=commitdiff;h=fd7b673c92731fc6c0b1e999adfd87b6762ee797
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-04-06 00:35    [W:0.087 / U:2.276 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site