lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] toshiba_acpi: Add support for transflective LCD
On Thu, Apr 05, 2012 at 11:36:48PM +0900, Akio Idehara wrote:
> >> static const struct backlight_ops toshiba_backlight_data = {
> >> + .options = BL_CORE_SUSPENDRESUME,
> >
> > What's the reason for adding this? I don't see that it's useful unless
> > we're handling BL_CORE_SUSPENDED, which toshiba_acpi is not doing.
>
>
> The reason is to restore transflective status, which is always disabled
> after resuming. If BL_CORE_SUSPENDRESUME is added,
> set_lcd_state_status() is called from backlight_update_status() with
> stored brightness. So, when its brightness is 0, transflective status is
> enabled after resuming.

Okay, that makes sense.

Since you're in the neighborhood, would you mind fixing the whitespace
issues in the other fields of toshiba_backlight_data while you're at it?
Both get_brightness and update_status are indented using spaces rather
than a tab.

Thanks,
Seth



\
 
 \ /
  Last update: 2012-04-05 17:43    [W:0.902 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site