lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v8 0/2] Ethernet drivers for WIZnet chips
    From
    From: Mike Sinkovsky <msink@trikom.ru>
    Date: Wed, 4 Apr 2012 17:57:38 +0600

    > From: Mike Sinkovsky <msink@permonline.ru>
    >
    > Based on original driver from chip manufacturer, but nearly full rewite.
    > Tested and used in production with Blackfin BF531 embedded processor.
    >
    > Signed-off-by: Mike Sinkovsky <msink@permonline.ru>

    I don't see the appropriate changes in your patches to make
    sure that drivers/net/ethernet/{Kconfig,Makefile} consider
    and traverse down into the wiznet/ subdirectory.

    Furthermore, once that is fixed these drivers generate warnings
    when built:

    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.suspend’) [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.resume’) [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.freeze’) [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.thaw’) [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.poweroff’) [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default]
    drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.restore’) [enabled by default]

    It seems that the arguments and return types for these operations have
    changed since you worked on these patches, but this should be easy
    to fix up.

    Please cure these two issues and I'll happily put these new drivers
    into net-next, and meanwhile you can continue to work with Eric
    Dumazet to correct the TX flow control and locking issues.

    Thanks.
    \
     
     \ /
      Last update: 2012-04-05 03:17    [W:0.021 / U:30.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site