Messages in this thread | | | Date | Wed, 04 Apr 2012 17:18:33 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH] umem: fix up unplugging. |
| |
On 2012-04-04 16:20, Tao Guo wrote: > Hi Andrew, > > Thanks for your reply. > > Yes, without this patch the umem driver just doesn't work. > It is a bug introduced by commit 7eaceaccab5f40bbfda044629a6298616aeaed50. > In that patch, Jens removed the whole mm_unplug_device() function, > which used to be > the trigger to make umem start to work.
Hmm indeed, that's isn't terribly useful. Why aren't we just calling activate_card() on addition of a bio?
But your patch looks fine too, if it's tested it beats what we have.
-- Jens Axboe
| |