lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH-v3] Support M95040 SPI EEPROM
From
Hi,

Op 3 april 2012 19:17 heeft Wolfram Sang <w.sang@pengutronix.de> het
volgende geschreven:
>
>> > > > +#define EE_INSTR_BIT3_IS_ADDR  0x0010
>> > >
>> > > Is there some guarantee that this chip flag will always have this
>> > > meaning?
>> >
>> > ? This is a driver flag.
>>
>> Sorry, I don't see it set anywhere, so unclear on where it comes from.
>> I thought it was from a generic spi probe.
>
> Yeah, agreed, 'struct spi_eeprom' does not sound much like platform_data :/
> Thanks for checking.

The flag is indeed used in the platform initialization to enable the
"address bit" behavior, so you don't see it set anywhere in this patch
(and not anywhere in the kernel, since no board uses this flag yet).

Is it OK if we leave this patch like this?

Regards,
Ivo Sieben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-04-04 09:25    [W:0.068 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site