lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] cgroups: disallow attaching kthreadd
From
Date
On Wed, 2012-04-04 at 04:29 -0700, David Rientjes wrote:

> I've never seen a nack from Peter on this, I only remember discussing
> whether this needs to be isolated to only cpusets or whether it needs to
> be a generic cgroup thing and I've always argued in favor of localizing it
> to cpusets because that cgroup happens to care about cpu affinity where
> others don't and this is why cgroups have ->can_attach() functions. If a
> cgroup were created to have nothing to do with cpu affinity (only for
> collecting statistics for threads within it, for example), there's
> absolutely no reason why we need to exclude kthreadd.

Well, he didn't actually say "NAK", but was against it, which means
pretty much the same thing as NAK to me.. we can call it a nak.

> You know I've been very supportive of getting this fix included for
> cpusets in the past and I very much appreciate your time and patience in
> the review cycle. I'm hoping we can finally do this.

Whatever floats the boat works for me. Peter likes generic, you like
targeted. I like generic best too fwtw, but I don't get to make the
command decision, else you'd be saying revert, and I'd be saying NAK :)

-Mike



\
 
 \ /
  Last update: 2012-04-04 14:33    [from the cache]
©2003-2011 Jasper Spaans