Messages in this thread | | | From | "Aneesh Kumar K.V" <> | Subject | Re: [RFC][PATCH 2/7 v2] memcg: fix error code in hugetlb_force_memcg_empty() | Date | Mon, 30 Apr 2012 14:19:46 +0530 |
| |
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:
> EBUSY should be returned. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > mm/hugetlb.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 17ae2e4..4dd6b39 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1922,8 +1922,11 @@ int hugetlb_force_memcg_empty(struct cgroup *cgroup) > int ret = 0, idx = 0; > > do { > - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > + if (cgroup_task_count(cgroup) > + || !list_empty(&cgroup->children)) { > + ret = -EBUSY; > goto out; > + } > /* > * If the task doing the cgroup_rmdir got a signal > * we don't really need to loop till the hugetlb resource
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
-aneesh
| |