Messages in this thread | | | Date | Mon, 30 Apr 2012 13:15:44 +0530 | From | Raghavendra K T <> | Subject | Re: [PATCH RFC V6 2/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration |
| |
On 04/29/2012 06:57 PM, Avi Kivity wrote: > On 04/23/2012 01:00 PM, Raghavendra K T wrote: >> From: Raghavendra K T<raghavendra.kt@linux.vnet.ibm.com> >> >> Signed-off-by: Raghavendra K T<raghavendra.kt@linux.vnet.ibm.com> >> --- >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> index 6faa550..7354c1b 100644 >> --- a/arch/x86/kvm/x86.c >> +++ b/arch/x86/kvm/x86.c >> @@ -5691,7 +5691,9 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu, >> int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu, >> struct kvm_mp_state *mp_state) >> { >> - mp_state->mp_state = vcpu->arch.mp_state; >> + mp_state->mp_state = (vcpu->arch.mp_state == KVM_MP_STATE_HALTED&& >> + vcpu->arch.pv.pv_unhalted) ? >> + KVM_MP_STATE_RUNNABLE : vcpu->arch.mp_state; >> return 0; >> } > > Not pretty. Suggest rewriting using an if. >
Ok.. 'll rewrite.
| |