lkml.org 
[lkml]   [2012]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/41] nohz: Move nohz load balancer selection into idle logic
    Date
    [ ** BUGGY PATCH: I need to put more thinking into this ** ]

    We want the nohz load balancer to be an idle CPU, thus
    move that selection to strict dyntick idle logic.

    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Alessio Igor Bogani <abogani@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Avi Kivity <avi@redhat.com>
    Cc: Chris Metcalf <cmetcalf@tilera.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
    Cc: Geoff Levand <geoff@infradead.org>
    Cc: Gilad Ben Yossef <gilad@benyossef.com>
    Cc: Hakan Akkan <hakanakkan@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Kevin Hilman <khilman@ti.com>
    Cc: Max Krasnyansky <maxk@qualcomm.com>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephen Hemminger <shemminger@vyatta.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Sven-Thorsten Dietrich <thebigcorporation@gmail.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    ---
    kernel/time/tick-sched.c | 8 ++++----
    1 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
    index fc9f687..b79dea2 100644
    --- a/kernel/time/tick-sched.c
    +++ b/kernel/time/tick-sched.c
    @@ -398,8 +398,6 @@ static void tick_nohz_stop_sched_tick(struct tick_sched *ts, ktime_t now)
    * the scheduler tick in nohz_restart_sched_tick.
    */
    if (!ts->tick_stopped) {
    - select_nohz_load_balancer(1);
    -
    ts->last_tick = hrtimer_get_expires(&ts->sched_timer);
    ts->tick_stopped = 1;
    }
    @@ -449,8 +447,10 @@ static void __tick_nohz_idle_enter(struct tick_sched *ts)
    now = tick_nohz_start_idle(smp_processor_id(), ts);
    tick_nohz_stop_sched_tick(ts, now);

    - if (!was_stopped && ts->tick_stopped)
    + if (!was_stopped && ts->tick_stopped) {
    ts->idle_jiffies = ts->last_jiffies;
    + select_nohz_load_balancer(1);
    + }
    }

    /**
    @@ -552,7 +552,6 @@ static void tick_nohz_restart(struct tick_sched *ts, ktime_t now)
    static void tick_nohz_restart_sched_tick(struct tick_sched *ts, ktime_t now)
    {
    /* Update jiffies first */
    - select_nohz_load_balancer(0);
    tick_do_update_jiffies64(now);

    touch_softlockup_watchdog();
    @@ -610,6 +609,7 @@ void tick_nohz_idle_exit(void)
    tick_nohz_stop_idle(cpu, now);

    if (ts->tick_stopped) {
    + select_nohz_load_balancer(0);
    tick_nohz_restart_sched_tick(ts, now);
    tick_nohz_account_idle_ticks(ts);
    }
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2012-05-01 02:21    [W:0.028 / U:93.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site