Messages in this thread | | | Date | Mon, 30 Apr 2012 16:32:15 -0400 | From | Greg KH <> | Subject | Re: [PATCH] usb: cp210x: Added support for GPIO (CP2103/4/5) |
| |
On Mon, Apr 30, 2012 at 03:27:17PM -0500, Preston Fick wrote: > This fix contains several changes that allow toggling of GPIO on CP210x > devices that support it. Changes include: > * Added in part number support, necessary to see if the connected device > supports the GPIO functionality > * Added two IOCTLs and ioctl function to allow GET/SET of GPIO > * Added in new #defines for partnum support, new USB requests > * Changed "Config request types" section to contain more correct definitions > for request recipient
No, please break this out into one-patch-per-change, don't bundle all of this together into one, as I can't take it as-is, sorry.
Especially with those new ioctls...
thanks,
greg k-h
| |