[lkml]   [2012]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] hwmon: coretemp: fix oops on cpu unplug
    On Mon, Apr 30, 2012 at 08:28:10AM -0700, Guenter Roeck wrote:
    > Hi,
    > good catch. Couple of problems, though.
    > First, what number of cores are we talking about ? We should probably
    > increase NUM_REAL_CORES as well. Long term, we should get rid of the
    > dependency to prevent that problem from happening again, but that is a
    > different issue.

    It triggered by another bug. Cores on my 10-core processor have ids 0, 1,
    2, 8, 9, 16, 17, 18, 24, 25. :-/
    No need to change NUM_REAL_CORES at the moment.

    > Second, we'll need the same code in get_core_online(). Otherwise the
    > platform device can be created for the new core (if the core is
    > re-enabled) but will never be deleted.

    It has already handled in create_core_data().

    Kirill A. Shutemov

     \ /
      Last update: 2012-04-30 18:41    [W:0.022 / U:58.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site